Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/461 add pagination getuserprojects endpoint #504

Merged

Conversation

BartvanEijkelenburg
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I did not update API Controllers, if I did, I added/changed Postman tests
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Run the project.

Go to swagger or Postman, log in as bob bob.

Select the Get User projects endpoint and try it out with the pagination options.

Link to issue

Closes: #461

@BartvanEijkelenburg BartvanEijkelenburg marked this pull request as ready for review September 28, 2021 07:52
Copy link
Contributor

@MeesvanStraten MeesvanStraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments for postman tests.

@BartvanEijkelenburg BartvanEijkelenburg added the Hacktoberfest Label for the hacktoberfest label Oct 1, 2021
Copy link
Contributor

@DaveBouman DaveBouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@DaveBouman DaveBouman merged commit 27b8298 into develop Oct 4, 2021
@DaveBouman DaveBouman deleted the feature/461-add-pagination-getuserprojects-endpoint branch October 4, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label for the hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination to GetUserProjects endpoint
4 participants